Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addPattern: index out of range #252

Closed
daxzhuo opened this issue Oct 23, 2023 · 2 comments
Closed

addPattern: index out of range #252

daxzhuo opened this issue Oct 23, 2023 · 2 comments

Comments

@daxzhuo
Copy link

daxzhuo commented Oct 23, 2023

version v1.0.0
code position
https://github.com/timbray/quamina/blob/v1.0.0/core_matcher.go#L89C18-L89C18

if vals is empty will trigger an index out of range

testing pattern
{"data": {"field": []}}
@timbray
Copy link
Owner

timbray commented Oct 23, 2023

Oops, that looks like a bug. Thanks. Will dig in and fix.

timbray added a commit that referenced this issue Dec 8, 2023
@timbray
addresses issue #252
24ec5c4 
ignore fields with no values

Signed-off-by: Tim Bray <tbray@textuality.com>
@timbray
Copy link
Owner

timbray commented Dec 9, 2023

Fixed in #258

@timbray timbray closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timbray @daxzhuo