-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pat: add prefix pattern #190
Conversation
Codecov ReportBase: 95.93% // Head: 95.83% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 95.93% 95.83% -0.10%
==========================================
Files 17 17
Lines 2067 2114 +47
==========================================
+ Hits 1983 2026 +43
- Misses 60 62 +2
- Partials 24 26 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fixes: #62 Signed-off-by: Tim Bray <tbray@textuality.com>
Hmm, I guess I should bump version to 1.1.0, this is a new feature. |
You mean after merge, right? Agree, this is not just a patch release. |
OK, I just realized this PR is stupid because {"a": [ {"prefix": "foo"}]} is identical to
which is already implemented. So I will rewrite and with much less code. |
fixes: #62 Signed-off-by: Tim Bray <tbray@textuality.com>
Actually, I'm an idiot squared. That breaks if there's a |
Just nits left, I'll approve and let you decide whether you want to make small adjustments based on the review. At least reverting the |
fixes: #62 Signed-off-by: Tim Bray <tbray@textuality.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes: #62
Signed-off-by: Tim Bray tbray@textuality.com