Adjust parsing to handle a variety of test cases, in particular secondary units #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove an out of place partial sentence
Docs say this about this option "pretend to optimize your code, but actually introduce bugs"
This makes a number of tweaks to the regexes to improve parsing. I include test cases for everything now supported. There are still some formats that are not parsing perfectly, but this makes a number of improvements.
In terms of parsing correctness, this seems like a wash. In some cases it does get worse, but in other cases it is improved.
Improve PO Box/Flat handling and fix performance issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This makes fairly large changes to the regexes. My primary motivation is to better parse secondary unit types and numbers. I've included a number of new test cases.
I realize the changes are a bit ugly and probably brittle in some ways, but I thought I'd send this anyway. I've run them against a larger set of data and by and large it seems an improvement.
One thought I had while working on this was that it might be nice to localize all of the assignments to
%_. As you can see, I did that in a few spots as I found it helpful (and in a few cases, required). Doing this everywhere could make the behaviour more understandable, as right now I believe some of what we parse comes out of branches we backtrack out of.Thank you!