fix: No longer possible to prevent trigger #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timc/kbar/J625Zf1jowUr3R9pqXbn4K2oNTN2 |
|
@tommoor you'll still run into the issue when the command bar is opened on top of a modal, and hitting ESC will propagate and close the modal as well right? |
|
At least in Outline it isn't an issue because opening CMD+K steals focus away from the underlying modal |
|
I suppose that's the proper way of handling modals and dialogs in the first place 👍 |
timc1
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could prevent command bar from appearing by preventing default elsewhere in the host application. Since this change:
87db5bb#diff-d5312972da4ac728a05d23c05e373b0e32c1241c3381805a1f1e4a160449b0e7L50-L52
useCapturemeans it is no longer possible to prevent command bar from appearing.