Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ReactShadowRoot #173

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add support for ReactShadowRoot #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ export function useOuterClick(

React.useEffect(() => {
function handler(event) {
if (dom.current?.contains(event.target)) {
if (
dom.current?.contains(event.target) ||
// Add support for ReactShadowRoot
// @ts-expect-error wrong types, the `host` property exists https://stackoverflow.com/a/25340456
event.target === dom.current?.getRootNode().host
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Events inside the shadow DOM do bubble up to window, however their target will be the host element, not the actual element, because the shadow DOM incapsulate everything inside it.

) {
return;
}
cbRef.current();
Expand Down Expand Up @@ -123,4 +128,4 @@ export function isModKey(
event: KeyboardEvent | MouseEvent | React.KeyboardEvent
) {
return isMac ? event.metaKey : event.ctrlKey;
}
}