fix: shorcut conflicts #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timc/kbar/GpWCD37DsZunSSnZidMyxvbCz9DE |
timc1
force-pushed
the
fix/shortcut-conflicts
branch
from
c25dd50 to
9c19ece
Compare
|
What's needed to get this merged? Would gladly contribute if there's anything left to do! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
timc1
force-pushed
the
fix/shortcut-conflicts
branch
from
a5eb022 to
4b24272
Compare
|
@merlindru apologies for the delay here! I've been sitting on this implementation and reworked it this evening. We'll just need to add a few test cases for this, which I plan to handle tomorrow. |
timc1
force-pushed
the
fix/shortcut-conflicts
branch
from
c3cd903 to
988724b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200.
tinykeysfire off all handlers for every key sequence that is matched; ie shortcuts registered with[g, d]and[g]will both be called if a user pressesganddsequentially. In this case, we only want the[g, d]shortcut to be called.