fix: prevent the escape key from minimizing Safari #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari uses the escape key as a shortcut for exiting full screen. Stopping propagation is _not_ enough to prevent this behaviour. Use `preventDefault` instead of `stopPropagation` to avoid messing with the users' browser experience. Closes: timc1#264
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
timc1
reviewed
Dec 2, 2022
timc1
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari uses the escape key as a shortcut for exiting full screen. Stopping propagation is not enough to prevent this behaviour. Use
preventDefaultinstead ofin addition tostopPropagationto avoid messing with the users' browser experience.Closes: #264