rework action #96
Closed
rework action #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timc/kbar/EgdGirZnGMF5bR4HvEqcrfXHMpZW |
timc1
commented
Oct 25, 2021
src/types.ts
Outdated
Comment on lines
6
to
16
| export interface Action { | ||
| id: string; | ||
| name: string; | ||
| shortcut: string[]; | ||
| keywords: string; | ||
| keywords?: string; | ||
| shortcut?: string[]; | ||
| perform?: () => void; | ||
| section?: string; | ||
| parent?: ActionId | null | undefined; | ||
| children?: ActionId[]; | ||
| children?: ActionImpl[]; | ||
| icon?: string | React.ReactElement | React.ReactNode; | ||
| subtitle?: string; | ||
| } |
There was a problem hiding this comment.
Todo: cleanup types so that it is clear what users need to define themselves, and what is handled implicitly.
timc1
force-pushed
the
spike/rework-action
branch
from
429b4fd to
5eee869
Compare
timc1
force-pushed
the
spike/rework-action
branch
from
e0e26c7 to
ee6bbb0
Compare
timc1
force-pushed
the
spike/rework-action
branch
from
ee6bbb0 to
db56019
Compare
Merged
|
See #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62.
Rework actions into a separate object so we can keep logic for manipulating actions within a single interface.
This will make: