Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka-2.5 / Scala 2.13 #7

Merged
merged 8 commits into from
Jun 14, 2021
Merged

Akka-2.5 / Scala 2.13 #7

merged 8 commits into from
Jun 14, 2021

Conversation

fabianhjr
Copy link
Contributor

No description provided.

@fabianhjr
Copy link
Contributor Author

There are still some issues and testing to be done.

The first of the Components test doesn't pass, it is the only one that doesn't.

Co-authored-by: Victor Hugo Borja <vborja@apache.org>
@fabianhjr fabianhjr marked this pull request as ready for review July 7, 2020 17:42
@vic
Copy link
Contributor

vic commented Jul 7, 2020

Closes #6

@vic
Copy link
Contributor

vic commented Jul 7, 2020

Hello @timcharper,

We've been trying to upgrade this project to at least akka 2.5 as a first step to later upgrade to current akka 2.6.

As @fabianhjr commented, we've tried to re-implement the BundlingBuffer component but we are a bit stuck on a failing test (all other tests are green).

Could you please review the changes, particularly on BundlingBuffer and perhaps enlighten us on what we are missing ?

Thank you.

@vic
Copy link
Contributor

vic commented Jul 15, 2020

Good news! All tests green now thanks to @davoclavo

Co-authored-by: David Gomez Urquiza <david.gurquiza@gmail.com>
@vic
Copy link
Contributor

vic commented Jul 16, 2020

@timcharper, this branch is now ready for review :)

@fabianhjr fabianhjr changed the title WIP: Akka-2.5 / Scala 2.13 Akka-2.5 / Scala 2.13 Jul 16, 2020
@vhnguyenae
Copy link

vhnguyenae commented Nov 14, 2020

hi can this PR be merged?
I'm interested since I want to migrate my project to scala 2.13 and I need this to use with op-rabbit-akka-stream 2.13 :-)

@davoclavo
Copy link
Contributor

davoclavo commented Nov 14, 2020

@vhnguyenae hopefully we get to merge this, meanwhile you can use our published artifact on jitpack:
using sbt:

    resolvers += "jitpack" at "https://jitpack.io"

    libraryDependencies += "com.github.deal-engine.acked-stream" %% "acked-streams" % "8f17c92"

@snovgorodtsev-zz
Copy link

Hello @davoclavo ! Just wondering if you're also planning to publish op-rabbit Scala 2.13 version somewhere? ;-)

@davoclavo
Copy link
Contributor

davoclavo commented May 17, 2021

@snovgorodtsev Hello, we indeed have a version published for scala 2.13 in our company's fork (link to branch here)

 resolvers += "jitpack" at "https://jitpack.io"

 libraryDependencies += "com.github.deal-engine.op-rabbit" %% "op-rabbit-core" % "a6f2dea2"

EDIT: I updated the version as it was incorrect

@timcharper timcharper merged commit 0faf902 into timcharper:master Jun 14, 2021
@fabianhjr
Copy link
Contributor Author

Thanks for the merge timcharper! UWU

@snovgorodtsev-zz
Copy link

Hey @fabianhjr ! Do you mind to publish a new version, please? Thanks.

@fabianhjr
Copy link
Contributor Author

@snovgorodtsev I cannot publish a new version.

@snovgorodtsev-zz
Copy link

Oh sorry I meant @timcharper of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants