add slightly deeper checking for a 'browser' environment. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (a Rhino based js runtime) there is a global [window] variable defined, which caused this check to fall short.
timdown
added a commit
that referenced
this pull request
Jan 14, 2015
add slightly deeper checking for a 'browser' environment.
|
That seems a reasonable and pragmatic solution. Thanks. |
|
Jolly good. By the way, even though I may try to provide a pull request for I'd love to hear your thoughts on my other email when you get time. On Wed, Jan 14, 2015 at 3:31 PM, Tim Down notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NetSuite (a Rhino based js runtime) there is a global [window] variable defined, which caused this check to fall short.