Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing index declaration #462

Closed
wants to merge 1 commit into from
Closed

Add missing index declaration #462

wants to merge 1 commit into from

Commits on Jan 8, 2020

  1. Add missing index declaration 

    When using the postApply function from undoToRange() on multiple ranges this error occured :

ERROR ReferenceError: i is not defined
    at ClassApplier.postApply (rangy-classapplier.js:741)
    at ClassApplier.undoToRange (rangy-classapplier.js:976)
    at HighlighterDirective.undo (***.directive.ts:52)
    at HighlighterDirective.set ranges [as ranges] (***.directive.ts:19)
    at updateProp (core.js:32189)
    at checkAndUpdateDirectiveInline (core.js:31867)
    at checkAndUpdateNodeInline (core.js:44367)
    at checkAndUpdateNode (core.js:44306)
    at debugCheckAndUpdateNode (core.js:45328)
    at debugCheckDirectivesFn (core.js:45271)

This error is simply due to missing "let" in line 744. 

Thanks for your pretty good library ;)
    @JLighter
    JLighter authored Jan 8, 2020
    Configuration menu
    Copy the full SHA
    b778ed0 View commit details
    Browse the repository at this point in the history