Panic if NaN is passed to Duration constructors

time-rs · Sep 25, 2022 · 9516a7e · lopopolo · Sep 25, 2022 · jhpratt
1 parent 8cb9c44
commit 9516a7e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/duration.rs b/src/duration.rs
@@ -323,6 +323,9 @@ impl Duration {
         if seconds > i64::MAX as f64 || seconds < i64::MIN as f64 {
             crate::expect_failed("overflow constructing `time::Duration`");
         }
+        if seconds.is_nan() {
+            crate::expect_failed("passed NaN to `time::Duration::seconds_f64`");
+        }
         Self::new_unchecked(seconds as _, ((seconds % 1.) * 1_000_000_000.) as _)
 seconds: seconds as i64, 
 rust: [1.32.0, 1.36.0, stable] 
 seconds: seconds as i64, 
 rust: [1.32.0, 1.36.0, stable] 
     }
 
@@ -337,6 +340,9 @@ impl Duration {
         if seconds > i64::MAX as f32 || seconds < i64::MIN as f32 {
             crate::expect_failed("overflow constructing `time::Duration`");
         }
+        if seconds.is_nan() {
+            crate::expect_failed("passed NaN to `time::Duration::seconds_f32`");
+        }
         Self::new_unchecked(seconds as _, ((seconds % 1.) * 1_000_000_000.) as _)
     }
 

diff --git a/tests/integration/duration.rs b/tests/integration/duration.rs
@@ -186,6 +186,7 @@ fn seconds_f64() {
 
     assert_panic!(Duration::seconds_f64(f64::MAX));
     assert_panic!(Duration::seconds_f64(f64::MIN));
+    assert_panic!(Duration::seconds_f64(f64::NAN));
 }
 
 #[test]
@@ -206,6 +207,7 @@ fn seconds_f32() {
 
     assert_panic!(Duration::seconds_f32(f32::MAX));
     assert_panic!(Duration::seconds_f32(f32::MIN));
+    assert_panic!(Duration::seconds_f32(f32::NAN));
 }
 
 #[test]