Call deserialization methods directly if possible

time-rs · May 1, 2022 · f9398b9 · f9398b9
1 parent 81b2bed
commit f9398b9
Show file tree

Hide file tree

Showing 3 changed files with 286 additions and 36 deletions.
diff --git a/src/serde/mod.rs b/src/serde/mod.rs
@@ -95,7 +95,11 @@ impl Serialize for Date {
 
 impl<'a> Deserialize<'a> for Date {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(2, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion date
@@ -118,7 +122,11 @@ impl Serialize for Duration {
 
 impl<'a> Deserialize<'a> for Duration {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(2, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion Duration
@@ -161,7 +169,11 @@ impl Serialize for OffsetDateTime {
 
 impl<'a> Deserialize<'a> for OffsetDateTime {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(9, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion OffsetDateTime
@@ -199,7 +211,11 @@ impl Serialize for PrimitiveDateTime {
 
 impl<'a> Deserialize<'a> for PrimitiveDateTime {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(6, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion PrimitiveDateTime
@@ -233,7 +249,11 @@ impl Serialize for Time {
 
 impl<'a> Deserialize<'a> for Time {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(4, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion Time
@@ -270,7 +290,11 @@ impl Serialize for UtcOffset {
 
 impl<'a> Deserialize<'a> for UtcOffset {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_tuple(3, Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion UtcOffset
@@ -291,7 +315,11 @@ impl Serialize for Weekday {
 
 impl<'a> Deserialize<'a> for Weekday {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_u8(Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion Weekday
@@ -312,7 +340,11 @@ impl Serialize for Month {
 
 impl<'a> Deserialize<'a> for Month {
     fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error> {
-        deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        if cfg!(feature = "serde-human-readable") && deserializer.is_human_readable() {
+            deserializer.deserialize_any(Visitor::<Self>(PhantomData))
+        } else {
+            deserializer.deserialize_u8(Visitor::<Self>(PhantomData))
+        }
     }
 }
 // endregion Month
diff --git a/src/serde/visitor.rs b/src/serde/visitor.rs
@@ -284,7 +284,7 @@ impl<'a> de::Visitor<'a> for Visitor<Option<well_known::Rfc2822>> {
         deserializer: D,
     ) -> Result<Option<OffsetDateTime>, D::Error> {
         deserializer
-            .deserialize_any(Visitor::<well_known::Rfc2822>(PhantomData))
+            .deserialize_option(Visitor::<well_known::Rfc2822>(PhantomData))
             .map(Some)
     }
 
@@ -319,7 +319,7 @@ impl<'a> de::Visitor<'a> for Visitor<Option<well_known::Rfc3339>> {
         deserializer: D,
     ) -> Result<Option<OffsetDateTime>, D::Error> {
         deserializer
-            .deserialize_any(Visitor::<well_known::Rfc3339>(PhantomData))
+            .deserialize_option(Visitor::<well_known::Rfc3339>(PhantomData))
             .map(Some)
     }