-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for parsing/formatting as RFC-3339 with Serde #387
Comments
Yeah, this is doable. |
This should be completed (sans tests) on the |
…`time::OffsetDateTime`. This change should not have any semantic meaning and is being done to address RUSTSEC-2020-0071 (see #244) and RUSTSEC-20200159 (see #245). This is a breaking API change because some result types include create/updated timestamps. Consumers of the library will need to add a direct dependency on `time`. Note that `chrono` already uses `time` internally, so this change should not bloat transitive dependencies. For those needing serialization support of `OffsetDateTime` timestamps, the `time` crate offers this support with the `serde` feature flag. One small point of friction here is rfc3339 support. `time` has this support on [a branch](time-rs/time#387) that is blocked on a rust feature hitting stable, so I copied in a few lines of code from that branch to support deserializing rfc3339 timestamps.
…`time::OffsetDateTime` (#249) * Removes `chrono` and usages of `DateTime<Utc>` and replaces them with`time::OffsetDateTime`. This change should not have any semantic meaning and is being done to address RUSTSEC-2020-0071 (see #244) and RUSTSEC-20200159 (see #245). This is a breaking API change because some result types include create/updated timestamps. Consumers of the library will need to add a direct dependency on `time`. Note that `chrono` already uses `time` internally, so this change should not bloat transitive dependencies. For those needing serialization support of `OffsetDateTime` timestamps, the `time` crate offers this support with the `serde` feature flag. One small point of friction here is rfc3339 support. `time` has this support on [a branch](time-rs/time#387) that is blocked on a rust feature hitting stable, so I copied in a few lines of code from that branch to support deserializing rfc3339 timestamps. * depend on our fork of jsonwebtoken * cargo fmt * lock to specific rev on jsonwebtoken fork * self review changes * Update to new jsonwebtoken Co-authored-by: Colt Frederickson <coltfred@gmail.com>
I'm not sure I understand the concern here. The whole mod |
I have a plan to get this to work. I am just working on something else first. |
I thought about putting this behind the This is on main now — both RFC3339 and RFC2822. Tests will be added for this soon. |
Hi! Are |
Not yet, no. It was just merged recently. There be a release soon-ish once some other changes get finalized. |
Issue #232 has added support for parsing and formatting timestamps using the RFC-3339. However, as best as I can tell, it only supports this in explicit code. It would be useful if this was supported in the Serde feature as well.
For example, instead of needing to do:
I could just do:
The text was updated successfully, but these errors were encountered: