Document #293 in local-offset feature description #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the feature flag for local-offset indicating that the feature is useless on unix platforms, with a reference to #293.
I just spent longer than I wanted trying to figure out why
OffsetDateTime::try_local_now
was returning IndeterminateDateTime. The path I had to take to figure it out:OffsetDateTime::try_now_local
. No mention of the issue.UtcOffset::local_offset_at
. No mention.try_local_offset_at
. Reference to The call tolocaltime_r
may be unsound #293.localtime_r
may be unsound #293. Issue is marked resolved.Hopefully a mention on the documentation for the feature flag will prevent others from having to follow that same path.