-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nicer Debug implementations #509
Conversation
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 99.42% 99.04% -0.39%
==========================================
Files 70 70
Lines 7186 7254 +68
==========================================
+ Hits 7145 7185 +40
- Misses 41 69 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's do this. Only change is deduplication, as the PR as-is needlessly doubles up the code.
You'll also need to rebase, though this shouldn't cause any conflicts. This is because I updated CI, so it won't pass on the PR unless it's rebased.
37a5fe7
to
cec2e41
Compare
It appears as though nothing has been changed since my previous comment. Did you forget to push something? Also don't worry about the codecov/project. That's on my end. It dropped for a reason I'm not certain about. |
Same as Display for now
My bad :) Should be good now. |
Looks good now! I'll take a final look over once I'm on my laptop. I also want to look into the internal compiler error when generating coverage, as that should never happen (not your fault). |
Unfortunately I am able to reproduce the internal compiler error on the currently nightly. This is unrelated to this PR, as I can reproduce it on the current main. Consequently I see no reason not to merge this. Thank you! |
Same as Display for now
Closes #503.