Fix sub-second negative Duration serialization.

[vriesk]

This addresses the problem that the Duration's sign will "disappear" both during serialization and deserialization of sub-second Durations.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (4a74924) to head (fa1e57a).
Report is 46 commits behind head on main.

❗ Current head fa1e57a differs from pull request most recent head 9a7603f

Please upload reports for the commit 9a7603f to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #692     +/-   ##
=======================================
- Coverage   97.8%   97.7%   -0.1%     
=======================================
  Files         81      83      +2     
  Lines       9378    8984    -394     
=======================================
- Hits        9169    8777    -392     
+ Misses       209     207      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vriesk]

PTAL

[vriesk]

PTAL? :)

[jhpratt]

This is still waiting on resolution to the changed comment.

[vriesk]

OK. But I replied there a while ago. I can just remove the comment change from the PR if you still disagree with me.

…

On Sun, 22 Sep 2024 at 00:47, Jacob Pratt ***@***.***> wrote: This is still waiting on resolution to the changed comment. — Reply to this email directly, view it on GitHub <#692 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYQ56TNCSZ3CNVFOCYALETZXXZQ5AVCNFSM6AAAAABKPHZQTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM2DKNZVHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jhpratt]

That is what I had initially requested, yes.

[vriesk]

That is what I had initially requested, yes.

Done, PTAL.

[jhpratt]

Sorry, I did not mean to close this! It happened automatically (somehow) when force-pushing a rebase.

Due to a quirk of GitHub, any PR that is force-pushed after being closed cannot be re-opened. As such I'll be merging it manually, so as to avoid making you open a new PR. You're still credited as the author 🙂