Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rstest and rstest_reuse; bump MSRV to 1.67.1 #716

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

musicinmybrain
Copy link
Contributor

These two updates aren’t inherently linked, but I thought it made sense to do them together.

I confirmed that cargo test still works in the time/ directory (the only crate that currently uses these workspace crates).

@musicinmybrain
Copy link
Contributor Author

error: package `rstest_macros v0.23.0` cannot be built because it requires rustc 1.67.1 or newer, while the currently active rustc version is 1.67.0

The README advertises at least the current stable Rust (now 1.82) and two prior minor releases, which would be 1.80. I’m assuming it should be OK to bump the MSRV to 1.67.1, since even 1.68 would mean supporting 14 prior minor releases. I’m going to attempt that in a follow-up commit.

@musicinmybrain musicinmybrain changed the title Update rstest to 0.23.0 and rstest_reuse to 0.7.0 (their latest versions) Update rstest and rstest_reuse; bump MSRV to 1.67.1 Nov 15, 2024
@jhpratt
Copy link
Member

jhpratt commented Nov 15, 2024

What is the benefit to bumping the dependency version?

@musicinmybrain
Copy link
Contributor Author

My motivation is that I am updating the rust-rstest package in Fedora, and that required patching our rust-time package to allow the latest version. (We can use parallel-installable compat packages to maintain older versions of crate library packages in the distribution as needed, but these are a maintenance burden when they proliferate too much, so we try to only create compat packages when they are really necessary.) Since we have a policy of offering patches upstream, I opened this PR.

From an upstream perspective, I think it’s usually easier to update dev dependencies periodically in smallish steps rather than keep the same versions indefinitely until something breaks, but that’s a matter of opinion. I’m not aware of any concrete reason these dependencies need to be updated right now, so you can certainly just close this PR and move on if you don’t find it useful.

@jhpratt
Copy link
Member

jhpratt commented Nov 15, 2024

I'm not necessarily opposed to this; I'll almost certainly end up merging it given the minimal impact. I'm asking all of this out of curiosity more than anything. What does Fedora need rust-rstest for, given that it's a dev dependency? Shouldn't crates be able to do all of this themselves?

@decathorpe
Copy link

What does Fedora need rust-rstest for, given that it's a dev dependency?

Because we - when possible - run tests for the crates we package.

@jhpratt jhpratt merged commit 1e19827 into time-rs:main Dec 3, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants