Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/issue 425 multishard incorrect result on distinct #784

Merged
merged 10 commits into from
Aug 29, 2024
Merged

Bugfix/issue 425 multishard incorrect result on distinct #784

merged 10 commits into from
Aug 29, 2024

Conversation

lizhou1111
Copy link
Contributor

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
this close #425

@lizhou1111 lizhou1111 self-assigned this Jun 28, 2024
@lizhou1111 lizhou1111 marked this pull request as draft June 28, 2024 13:25
@Jasmine-ge Jasmine-ge assigned Jasmine-ge and unassigned lizhou1111 Aug 13, 2024
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from dc5a941 to 57973ce Compare August 20, 2024 05:39
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from 57973ce to 5d4b022 Compare August 20, 2024 07:01
@Jasmine-ge Jasmine-ge marked this pull request as ready for review August 20, 2024 07:03
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from 5d4b022 to fc5a0e7 Compare August 20, 2024 07:15
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch 4 times, most recently from 02c82b5 to 1bf25d4 Compare August 22, 2024 10:58
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from 58b2cfe to 9d54cb8 Compare August 26, 2024 02:54
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from a73f291 to 3b85c4c Compare August 26, 2024 06:08
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from 3b85c4c to 691b390 Compare August 26, 2024 06:27
@Jasmine-ge Jasmine-ge force-pushed the bugfix/issue-425-multishard-incorrect-result-on-distinct branch from 69d23ed to 10e815f Compare August 27, 2024 09:31
@Jasmine-ge Jasmine-ge merged commit 72c1db9 into develop Aug 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasmine-ge Jasmine-ge Jasmine-ge left review comments

@yl-lisen yl-lisen yl-lisen approved these changes

Assignees

@Jasmine-ge Jasmine-ge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multishard incorrect result on aggr_distinct (with append only stream)
4 participants
@lizhou1111 @CLAassistant @yl-lisen @Jasmine-ge