forked from slingdata-io/sling-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow direct insert #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tetoDB refactor writeto db to smaller function
with directy insert, we need to support more detailed column append otherwise, the column type will be changed to other type by infer, and we cannot append data through go driver directly
the final table must exist this is a very strong requirement, but make everything more stable/robust/easier reason: infer type cause insert not work usually.
also enhance the retry logic in task_run.go
not work, let me refine |
It turns out that in the local build I previously used an option to disable optimization for debugging. When I later deactivated them, I got a 3x boost. However, this is different from the release created by goreleaser. This is because the default goreleaser YAML usage is quite simple, with binary version LDflags. |
reason: the createtmp will assign an unique id
jovezhong
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about making a big PR, probably I can start earlier to split this big PR.
things summary:
insert select
will timeout sometimes)/app
or localsling_transfer
folder.We plan to eliminate the timeout issue during partial inserts by directly writing to the target table instead of using a temporary table. However, when we directly write to the target table, handling type conversion and inference may be a bit tricky. I decided that users will need to create the target table themselves.
TODO: