Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add rules to no danmaku #52

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: add rules to no danmaku #52

merged 1 commit into from
Nov 4, 2024

Conversation

timerring
Copy link
Owner

Description

If no danmaku files are generated in certain specific situations, then skip the danmaku burning process.

Related Issues

fix #51

Who Can Review?

@timerring

TODO

None

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added enhancement New feature or request bug fix labels Nov 4, 2024
@timerring timerring self-assigned this Nov 4, 2024
timerring
timerring commented Nov 4, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timerring timerring merged commit 10880f0 into main Nov 4, 2024
@timerring timerring deleted the dev branch November 4, 2024 14:42
@timerring timerring mentioned this pull request Nov 4, 2024
Closed
timerring added a commit that referenced this pull request Nov 4, 2024
@timerring
perf: as a supplement to #52
5847063 
close #33
@timerring timerring mentioned this pull request Nov 4, 2024
Merged
7 tasks
timerring added a commit that referenced this pull request Nov 4, 2024
@timerring
perf: as a supplement to #52 (#53)
b4eb6b3 
close #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timerring timerring

Labels
bug fix enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Special rules for no danmaku files
1 participant
@timerring