Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial about preloaded data #2616

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Add partial about preloaded data #2616

merged 6 commits into from
Aug 28, 2023

Conversation

Loquacity
Copy link
Contributor

Description

Adds a partial to link to queries if you have pre-loaded data

Links

Fixes #[insert issue link, if any]

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@Loquacity Loquacity requested review from solugebefola and a team August 9, 2023 10:21
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-preload-nyc-lana

Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! Only question: are the preloaded data only for nyc taxi tutorial?

@Loquacity
Copy link
Contributor Author

LGTM!!!! Only question: are the preloaded data only for nyc taxi tutorial?

For now, yes. I think having it in a partial is a good idea, though, because then if we add other pre-loaded datasets later, we can reuse it.

@Loquacity Loquacity merged commit d3ccf4a into latest Aug 28, 2023
2 checks passed
@Loquacity Loquacity deleted the preload-nyc-lana branch August 28, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants