Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-node deprecation warning #3547

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

jonatas
Copy link
Contributor

@jonatas jonatas commented Oct 30, 2024

Description

I just see that data_nodes informational view does not have the deprecation notice. Just copied the import from other files.

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-add-deprecation-warning-to-data-nodes

Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Iain Cox <iain@timescale.com>
# timescaledb_information.data_nodes

Get information on data nodes. This function is specific to running
TimescaleDB in a multi-node setup.

<MultiNodeDeprecation />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @billy-the-fish! I end up just grepping and missed the tag 🤦

@jonatas jonatas enabled auto-merge (squash) November 14, 2024 12:56
@jonatas jonatas merged commit 6d75eff into latest Nov 14, 2024
3 checks passed
@jonatas jonatas deleted the add-deprecation-warning-to-data-nodes branch November 14, 2024 12:57
billy-the-fish added a commit that referenced this pull request Nov 19, 2024
Signed-off-by: Iain Cox <iain@timescale.com>
Co-authored-by: Iain Cox <iain@timescale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants