Skip to content

Horizontal read scaling #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

atovpeko
Copy link
Contributor

@atovpeko atovpeko commented Apr 16, 2025

Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-297-docs-rfc-new-docs-for-load-balancing-horizontal-scaling

Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small nits. Good doc.

atovpeko and others added 8 commits April 17, 2025 17:59
Co-authored-by: Iain Cox <iain@timescale.com>
Signed-off-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Co-authored-by: Iain Cox <iain@timescale.com>
Signed-off-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Co-authored-by: Iain Cox <iain@timescale.com>
Signed-off-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
@billy-the-fish billy-the-fish marked this pull request as draft April 25, 2025 09:27
@ramonguiu
Copy link
Contributor

ramonguiu commented May 18, 2025

I'll review in more detail but some high level feedback:

  • I am not sure I would keep HA and Read Replicas in the same section. While replication is the technical solution for both, they are very different JTBD (jobs to be done). I would consider using Read scaling in the title instead of read replication.
  • The name of the feature now is “read replica set” , not read replica.
  • We have to mention horizontal scaling in the content.

@atovpeko
Copy link
Contributor Author

Hi @ramonguiu, thank you for reviewing! To address your comments:

  • I have renamed the page as requested and mentioned horizontal scaling front and center.
  • This page will go under a big "Operate and scale" section during the upcoming doc restructure, so it won't be grouped with HA.
  • At the time of writing this, the designs still used both terms - read replica and read replica set - so I stuck to the old one. Updated now.
  • Waiting when this is on dev to update the workflow, this is very outdated now. Will be happy to get your detailed review then.

@billy-the-fish billy-the-fish marked this pull request as ready for review May 29, 2025 07:46
…orizontal-scaling

Signed-off-by: Iain Cox <iain@timescale.com>
@ramonguiu
Copy link
Contributor

I think we could add an architecture diagram to better illustrate the solution. There is one in the blog post (not sure if it's final): https://docs-dev.timescale.com/docs-297-docs-rfc-new-docs-for-load-balancing-horizontal-scaling/use-timescale/297-docs-rfc-new-docs-for-load-balancing-horizontal-scaling/ha-replicas/read-scaling/

atovpeko and others added 7 commits June 2, 2025 10:48
Co-authored-by: Ramon Guiu <ramon@timescale.com>
Signed-off-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Co-authored-by: Ramon Guiu <ramon@timescale.com>
Signed-off-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
…alancing-horizontal-scaling' into 297-docs-rfc-new-docs-for-load-balancing-horizontal-scaling
ramonguiu added 2 commits June 2, 2025 06:58
Signed-off-by: Ramon Guiu <ramon@timescale.com>
Signed-off-by: Ramon Guiu <ramon@timescale.com>
@ramonguiu ramonguiu self-requested a review June 2, 2025 13:59
@atovpeko atovpeko merged commit ea89fc6 into latest Jun 2, 2025
4 checks passed
@atovpeko atovpeko deleted the 297-docs-rfc-new-docs-for-load-balancing-horizontal-scaling branch June 2, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants