Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load api keys from db in self hosted vectorizer #311

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat: load api keys from db in self hosted vectorizer #311

merged 3 commits into from
Dec 18, 2024

Conversation

Askir
Copy link
Contributor

@Askir Askir commented Dec 16, 2024 •
edited
Loading

So you don't have to set e.g. the OPENAI_API_KEY in two places.

@Askir Askir requested a review from a team as a code owner December 16, 2024 16:50
smoya
smoya reviewed Dec 16, 2024
View reviewed changes
projects/pgai/pgai/cli.py Outdated Show resolved Hide resolved
cevian
cevian reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Leaving the eval of the testing to other reviewers

docs/vectorizer-quick-start-openai.md Outdated Show resolved Hide resolved
projects/pgai/pgai/cli.py Show resolved Hide resolved
JamesGuthrie
JamesGuthrie approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@JamesGuthrie JamesGuthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

projects/pgai/pgai/cli.py Show resolved Hide resolved
@Askir Askir force-pushed the jascha/ai-257-self-hosted-vectorizer-fetch-secrets-from-db branch from 775f51e to 69cb0ce Compare December 18, 2024 10:29
@Askir Askir force-pushed the jascha/ai-257-self-hosted-vectorizer-fetch-secrets-from-db branch from 69cb0ce to f40bd34 Compare December 18, 2024 10:30
@Askir Askir merged commit b7573b7 into main Dec 18, 2024
5 checks passed
@Askir Askir deleted the jascha/ai-257-self-hosted-vectorizer-fetch-secrets-from-db branch December 18, 2024 10:35
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya left review comments

@cevian cevian cevian left review comments

@JamesGuthrie JamesGuthrie JamesGuthrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Askir @cevian @smoya @JamesGuthrie