Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use psycopg over psycopg2 for sqlalchemy tests #326

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

MasterOdin
Copy link
Contributor

PR replaces usage of psycopg2 with psycopg for the sqlalchemy tests that were added in #265, as we already were installing psycopg for other tests, and that installing psycopg2 can be a bit annoying for folks on macOS (see psycopg/psycopg2#1200 as an example).

Signed-off-by: Matthew Peveler <mpeveler@timescale.com>
@MasterOdin MasterOdin requested a review from a team as a code owner December 20, 2024 17:38
Copy link
Contributor

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!💯💯💯

@MasterOdin MasterOdin merged commit 8c5baf7 into main Dec 20, 2024
5 checks passed
@MasterOdin MasterOdin deleted the mpeveler/dev-psycopg branch December 20, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants