Skip to content

Commit

Permalink
Change stats_agg::tests::pg_stats_agg_fuzz to allow more variance.
Browse files Browse the repository at this point in the history
aarch64 varies a lot more on "covar_pop" and "covar_samp".
We investigated a bit and found that the postgresql equivalents
we were comparing against varied further from amd64 behavior than
toolkit's.  Possibly differences between gcc and llvm code-gen?

for issue #422
  • Loading branch information
epgts committed May 26, 2022
1 parent d3295c0 commit e6144bf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions extension/src/stats_agg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1627,8 +1627,8 @@ mod tests {
check_agg_equivalence(state, &client, &pg2d_agg("regr_intercept"), &tk2d_agg("intercept"), EPS1);
// check_agg_equivalence(&state, &client, &pg2d_agg(""), &tk2d_agg("x_intercept"), 0.0000001); !!! No postgres equivalent for x_intercept
check_agg_equivalence(state, &client, &pg2d_agg("regr_r2"), &tk2d_agg("determination_coeff"), EPS1);
check_agg_equivalence(state, &client, &pg2d_agg("covar_pop"), &tk2d_agg_arg("covariance", "population"), EPS1);
check_agg_equivalence(state, &client, &pg2d_agg("covar_samp"), &tk2d_agg_arg("covariance", "sample"), EPS1);
check_agg_equivalence(state, &client, &pg2d_agg("covar_pop"), &tk2d_agg_arg("covariance", "population"), BILLIONTH);
check_agg_equivalence(state, &client, &pg2d_agg("covar_samp"), &tk2d_agg_arg("covariance", "sample"), BILLIONTH);

// Skewness and kurtosis don't have aggregate functions in postgres, but we can compute them
check_agg_equivalence(state, &client, &pg_moment_pop_query(3, "test_x"), &tk1d_agg_arg("skewness", "population"), BILLIONTH);
Expand Down

0 comments on commit e6144bf

Please sign in to comment.