Switch stabilization tests to new info #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtwalker
reviewed
Mar 11, 2022
There was a problem hiding this comment.
There is also a use of INT here
timescaledb-toolkit/extension/src/lttb.rs
Line 97 in a632634
There are multiple ways to refer to the integer type in SQL. The canonical one is `integer`, and that's the one the scripts understand the best, so update our remaining uses of `int` to `integer` for consistency, and if hopes that if anyone copy/pastes a CREATE AGGREGATE line for inspiration they'll use the correct name.
This commit switches the stabilization tests to the new stabilization info file, meaning there's exactly one central location that decides if things are stable. It also cleans the actual stabilization test code, and documents what invariants we're trying to maintain.
JLockerman
force-pushed
the
jl/stabalization-test
branch
from
7776464 to
97e3a56
Compare
WireBaron
approved these changes
Mar 30, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches the stabilization tests to the new stabilization info file, meaning there's exactly one central location that decides if things are stable. It also cleans the actual stabilization test code, and documents what invariants we're trying to maintain.