Remove GUC

docs/timeseries.md

@@ -31,11 +31,6 @@ INSERT INTO test
 INSERT 0 4032
 ```
 
-While still expermental, we'll need to set this before creating our view:
-```SQL , non-transactional,ignore-output
-    SET timescaledb_toolkit_acknowledge_auto_drop TO 'true';
-```
-
 Now lets capture this data into a time series which we'll store in a view.
 
 ```SQL ,non-transactional,ignore-output

docs/timeseries_pipeline_elements.md

@@ -47,7 +47,6 @@ INSERT INTO test_data
 
 Now suppose we want to know how much the temperature fluctuates on a daily basis for each device.  Using timevector and pipelines can simplify the process of finding the answer:
 ```SQL ,non-transactional,ignore-output
-SET timescaledb_toolkit_acknowledge_auto_drop TO 'true';
 CREATE VIEW daily_delta AS
     SELECT device,
         toolkit_experimental.timevector(time, temperature)

extension/src/frequency.rs

@@ -736,11 +736,6 @@ mod tests {
                 .get_one::<String>()
                 .unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select(
-                "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'",
-                None,
-                None,
-            );
 
             client.select("SET TIMEZONE to UTC", None, None);
             client.select(
@@ -775,11 +770,6 @@ mod tests {
                 .get_one::<String>()
                 .unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select(
-                "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'",
-                None,
-                None,
-            );
 
             client.select("SET TIMEZONE to UTC", None, None);
             client.select(
@@ -1016,11 +1006,6 @@ mod tests {
             .get_one::<String>()
             .unwrap();
         client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-        client.select(
-            "SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'",
-            None,
-            None,
-        );
 
         client.select("SET TIMEZONE to UTC", None, None);
         client.select(

extension/src/lib.rs

@@ -34,19 +34,9 @@ use pgx::*;
 
 pgx::pg_module_magic!();
 
-static EXPERIMENTAL_ENABLED: GucSetting<bool> = GucSetting::new(false);
-
 #[pg_guard]
 pub extern "C" fn _PG_init() {
-    GucRegistry::define_bool_guc(
-        "timescaledb_toolkit_acknowledge_auto_drop",
-        "enable creation of auto-dropping objects using experimental timescaledb_toolkit_features",
-        "experimental features are very unstable, and objects \
-            depending on them will be automatically deleted on extension update",
-        &EXPERIMENTAL_ENABLED,
-        //TODO should this be superuser?
-        GucContext::Userset,
-    );
+    // Nothing to do here
 }
 
 extension_sql!(r#"GRANT USAGE ON SCHEMA toolkit_experimental TO PUBLIC;"#,

extension/src/time_series/pipeline.rs

@@ -434,7 +434,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             client.select(
                 "CREATE TABLE lttb_pipe (series timevector)",
@@ -544,7 +543,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT timevector('2021-01-01'::timestamptz, 0.1) -> round() -> abs() -> round();",

extension/src/time_series/pipeline/aggregation.rs

@@ -722,7 +722,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -751,7 +750,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT \
@@ -785,7 +783,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -814,7 +811,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT \
@@ -847,7 +843,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -876,7 +871,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT \
@@ -909,7 +903,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -938,7 +931,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT \
@@ -971,7 +963,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -1031,7 +1022,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -1095,7 +1085,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -1141,7 +1130,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             let output = client.select(
                 "EXPLAIN (verbose) SELECT \

extension/src/time_series/pipeline/arithmetic.rs

@@ -280,7 +280,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -406,7 +405,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \

extension/src/time_series/pipeline/delta.rs

@@ -65,7 +65,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             client.select(
                 "CREATE TABLE series(time timestamptz, value double precision)",

extension/src/time_series/pipeline/expansion.rs

@@ -184,7 +184,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -215,7 +214,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // we use a subselect to guarantee order
             let create_series = "SELECT timevector(time, value) as series FROM \
@@ -244,7 +242,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             // `-> materialize()` should force materialization, but otherwise the
             // pipeline-folding optimization should proceed

extension/src/time_series/pipeline/fill_holes.rs

@@ -127,7 +127,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             client.select(
                 "CREATE TABLE gappy_series(time timestamptz, value double precision)",

extension/src/time_series/pipeline/fill_to.rs

@@ -129,7 +129,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             client.select(
                 "CREATE TABLE series(time timestamptz, value double precision)",

extension/src/time_series/pipeline/filter.rs

@@ -84,7 +84,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             client.select(
                 "CREATE TABLE series(time timestamptz, value double precision)",

extension/src/time_series/pipeline/lambda.rs

@@ -552,7 +552,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
             client.select("SELECT $$ let $1 = 1.0; 2.0, $1 $$::toolkit_experimental.lambda", None, None);
             // client.select("SELECT $$ '1 day'i $$::toolkit_experimental.lambda", None, None);
             // client.select("SELECT $$ '2020-01-01't $$::toolkit_experimental.lambda", None, None);
@@ -625,7 +624,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             bool_lambda_eq!(client, "2.0 <  3.0", "true");
             bool_lambda_eq!(client, "2.0 <= 3.0", "true");
@@ -666,7 +664,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             f64_lambda_eq!(client, "pi()",    std::f64::consts::PI);
 
@@ -707,7 +704,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             f64_lambda_eq!(client, "-(2.0)", -2.0f64);
             f64_lambda_eq!(client, "-(-2.0)", 2.0f64);
@@ -729,7 +725,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             interval_lambda_eq!(client, "'1 day'i + '1 day'i", "2 days");
             interval_lambda_eq!(client, "'1 day'i + '1 week'i", "8 days");
@@ -749,7 +744,6 @@ mod tests {
             // difficult to spot otherwise.
             let sp = client.select("SELECT format(' %s, toolkit_experimental',current_setting('search_path'))", None, None).first().get_one::<String>().unwrap();
             client.select(&format!("SET LOCAL search_path TO {}", sp), None, None);
-            client.select("SET timescaledb_toolkit_acknowledge_auto_drop TO 'true'", None, None);
 
             f64_lambda_eq!(client, "let $foo = 2.0; $foo", 2.0);
             f64_lambda_eq!(client, "let $foo = -2.0; $foo", -2.0);