Make some changes to support aarch64-unknown-linux-gnu #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It became "thin" in commit d18ebe6. Fixes segfaults on aarch64-unknown-linux-gnu (ron-rs/ron#379) Also drop redundant default overrides from profiles. for issue #422
aarch64 varies a lot more on "covar_pop" and "covar_samp". We investigated a bit and found that the postgresql equivalents we were comparing against varied further from amd64 behavior than toolkit's. Possibly differences between gcc and llvm code-gen? for issue #422
rtwalker
approved these changes
May 31, 2022
WireBaron
approved these changes
May 31, 2022
This is sadly not ready to be closed, but thanks! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ltoback to default offalse.(Crash with LTO on aarch64-unknown-linux-gnu ron-rs/ron#379)
We investigated a bit and found that the postgresql equivalents
we were comparing against varied further from amd64 behavior than
toolkit's. Possibly differences between gcc and llvm code-gen?
for issue #422