Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize accessors. #491

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Stabilize accessors. #491

merged 1 commit into from
Aug 16, 2022

Conversation

epgts
Copy link
Contributor

@epgts epgts commented Aug 8, 2022 •
edited
Loading

No description provided.

@epgts epgts force-pushed the eg/stabilize-accessors branch 2 times, most recently from d96ed20 to 08724e4 Compare August 11, 2022 18:12
@epgts epgts changed the title stabilize accessors Stabilize accessor Aug 11, 2022
@epgts epgts changed the title Stabilize accessor Stabilize accessors. Aug 11, 2022
@epgts epgts requested review from WireBaron and rtwalker August 11, 2022 18:13
@epgts epgts marked this pull request as ready for review August 11, 2022 18:14
@epgts epgts force-pushed the eg/stabilize-accessors branch from 08724e4 to 4e420e0 Compare August 15, 2022 17:06
WireBaron
WireBaron approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward, good to go.

@epgts epgts force-pushed the eg/stabilize-accessors branch 2 times, most recently from a5b3393 to 5b24113 Compare August 16, 2022 14:47
@epgts
Copy link
Contributor Author

epgts commented Aug 16, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2022

Build succeeded:

@bors bors bot merged commit ec8080c into main Aug 16, 2022
@bors bors bot deleted the eg/stabilize-accessors branch August 16, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WireBaron WireBaron WireBaron approved these changes

@rtwalker rtwalker Awaiting requested review from rtwalker

Assignees

@JLockerman JLockerman

@WireBaron WireBaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epgts @WireBaron @JLockerman