Create accessors to first/last data points #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These accessors expose the two fields (ts, val) of the TSPoints in each of the "first" and "last" fields for both TimeWeightSummary and CounterAgg.
rtwalker
requested review from
epgts,
davidkohn88,
WireBaron,
thatzopoulos and
jerryxwu
epgts
approved these changes
Sep 1, 2022
| last_time(timeweightsummary), | ||
| last_val(), | ||
| last_val(countersummary), | ||
| last_val(timeweightsummary), |
There was a problem hiding this comment.
It really is interesting to see how much a simple feature costs.
|
Does it make sense to have this for counter_agg but not gauge_agg? |
epgts
approved these changes
Sep 6, 2022
epgts
reviewed
Sep 6, 2022
|
bors r+ |
|
Build succeeded:
|
Discussed at standup today where it was agreed that it makes sense to wait on #523 to be sorted out before adding these functions to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #512
We can continue bike shedding the names either here or in the linked issue.
Just wanted to get the PR up.