Fix errors in hyperloglog implementation #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WireBaron
requested review from
rtwalker,
syvb,
JLockerman,
thatzopoulos,
davidkohn88 and
epgts
epgts
approved these changes
Sep 12, 2022
WireBaron
force-pushed
the
br/hyperloglog_fix_bias
branch
from
0d199d4 to
eb46d40
Compare
This change fixes bugs where the bias corrected estimated was first being calculated incorrectly, and then secondly not used. Tests have been updated to reflect the new implementation, and a new test has been added to randomly verify bias corrected results have an error less than 5%.
WireBaron
force-pushed
the
br/hyperloglog_fix_bias
branch
from
eb46d40 to
3e83279
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes bugs where the bias corrected estimated was first being calculated incorrectly, and then secondly not used. Tests have been updated to reflect the new implementation, and a new test has been added to randomly verify bias corrected results have an error less than 5%.
Fixes #469
Fixes #508