Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: bump actions/checkout and actions/cache to v3 #598

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

rtwalker
Copy link
Contributor

@rtwalker rtwalker commented Oct 31, 2022

We're seeing a lot of deprecation warnings on our CI runs lately e.g. https://github.com/timescale/timescaledb-toolkit/actions/runs/3359573483

which point to this blog post about deprecations in some GitHub Actions commands.

Bumping the checkout and cache actions appears to make many of these warnings go away.

@rtwalker rtwalker marked this pull request as draft October 31, 2022 16:52
@rtwalker rtwalker force-pushed the rw/bump-actions-checkout branch from d891cc0 to cb0f87b Compare October 31, 2022 17:54
we're seeing  a lot of deprecation warnings on our CI runs lately e.g.
https://github.com/timescale/timescaledb-toolkit/actions/runs/3359573483

which point to this blog post
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
about deprecations in some GitHub Actions commands.

Bumping the checkout and cache actions appears to make many of these
warnings go away.foo
@rtwalker rtwalker force-pushed the rw/bump-actions-checkout branch from cb0f87b to c02a5f9 Compare October 31, 2022 18:28
@rtwalker rtwalker changed the title GitHub Actions: bump actions/checkout to v3 GitHub Actions: bump actions/checkout and actions/cache to v3 Oct 31, 2022
@rtwalker
Copy link
Contributor Author

We also use these actions in .github/workflows/patch_build.yml.

I made similar changes there initially, but I got back (among other deprecation warnings from our Docker related actions)1:

Error response from daemon: Get "https://registry-1.docker.io/v2/": unauthorized: incorrect username or password

I removed changes to that file from this PR since it appears we haven't run that action in ~5 months, and I'm not eager to track down the username/password stuff at the moment.

The PR still at least removes the deprecation warnings that appear on the workflows that we frequently use.

Footnotes

  1. see https://github.com/timescale/timescaledb-toolkit/actions/runs/3363525906

@rtwalker rtwalker marked this pull request as ready for review October 31, 2022 19:32
@rtwalker
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

@bors bors bot merged commit 619563c into main Oct 31, 2022
@bors bors bot deleted the rw/bump-actions-checkout branch October 31, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants