Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new approx_percentile_array function #609

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add new approx_percentile_array function #609

merged 1 commit into from
Dec 5, 2022

Conversation

thatzopoulos
Copy link
Contributor

@thatzopoulos thatzopoulos commented Nov 9, 2022 •
edited
Loading

Added a new function that takes an array of percentiles and runs approx_percentile() on each of them, returning an array of results.

Closes #600

@thatzopoulos thatzopoulos changed the title Th/percent agg array Add new approx_percentile_array function Nov 16, 2022
@thatzopoulos thatzopoulos marked this pull request as ready for review November 16, 2022 20:14
@thatzopoulos thatzopoulos force-pushed the th/percent-agg-array branch 3 times, most recently from 47fe9dd to 8318e21 Compare November 17, 2022 19:10
rtwalker
rtwalker reviewed Nov 29, 2022
View reviewed changes
extension/src/accessors.rs Outdated Show resolved Hide resolved
extension/src/uddsketch.rs Outdated Show resolved Hide resolved
epgts
epgts suggested changes Dec 1, 2022
View reviewed changes
extension/src/uddsketch.rs Outdated Show resolved Hide resolved
@thatzopoulos thatzopoulos force-pushed the th/percent-agg-array branch 2 times, most recently from e165bae to b77b988 Compare December 5, 2022 17:42
@thatzopoulos
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

Build succeeded:

@bors bors bot merged commit 2310e63 into main Dec 5, 2022
@bors bors bot deleted the th/percent-agg-array branch December 5, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epgts epgts epgts approved these changes

@WireBaron WireBaron WireBaron approved these changes

@rtwalker rtwalker Awaiting requested review from rtwalker

@syvb syvb Awaiting requested review from syvb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function similar to approx_percentile that can take an array of percentiles as an argument
4 participants
@thatzopoulos @rtwalker @WireBaron @epgts