Stabilize Candlestick/OHLC #701
Conversation
thatzopoulos
force-pushed
the
th/stabilize-ohlc
branch
from
16bad26 to
0f2c020
Compare
| "LC_COLLATE 'C.UTF-8' LC_CTYPE 'C.UTF-8'" | ||
| } | ||
| _ => "LC_COLLATE 'C' LC_CTYPE 'C'", | ||
| match std::process::Command::new("locale").arg("-a").output() { |
There was a problem hiding this comment.
This wouldn't run on my mac when LC_CTYPE was set to UTF-8, but Smitty's match statement worked so I removed the cfg checks for target_os.
thatzopoulos
force-pushed
the
th/stabilize-ohlc
branch
from
0f2c020 to
7bdeb98
Compare
thatzopoulos
force-pushed
the
th/stabilize-ohlc
branch
2 times, most recently
from
e95a945 to
da54bfb
Compare
thatzopoulos
force-pushed
the
th/stabilize-ohlc
branch
from
da54bfb to
4ef9507
Compare
| ); | ||
|
|
||
| let output_buffer = state.unwrap().to_pg_bytes(); | ||
| let expected = [ |
There was a problem hiding this comment.
Not necessary if we don't have time, but moving forward it would be good if we can annotate this sort of output with an explanation of what it means just to make it clear that the output is correct (see explicit_aggregate_test in frequency.rs for an example).
| ('2023-01-11 11:12:12+00','PFE',47.38,14), | ||
| ('2023-01-11 11:01:50+00','AMZN',95.25,1000), | ||
| ('2023-01-11 11:01:32+00','AMZN',92,NULL), | ||
| ('2023-01-11 11:01:30+00','AMZN',75.225,NULL); |
There was a problem hiding this comment.
I would rather see just a few interesting buckets (several points, data doesn't just go up and to the right) than many uninteresting ones, but this is good enough here.
docs/test_candlestick_agg.md
Outdated
| daily_bucket | symbol | vwap | high | ||
| ------------------------+--------+------+--------- | ||
| 2023-01-11 00:00:00+00 | AAPL | NULL | 133.445 | ||
| daily_bucket | symbol | vwap | high |
There was a problem hiding this comment.
I'm not actually sure we need a rollup test here, since the cagg doesn't affect the rollup behavior at all, but if we want to have it we should look at a few more columns so we can make sure it's behaving like we expect.
|
bors r+ |
701: Stabilize Candlestick/OHLC r=thatzopoulos a=thatzopoulos This PR renames ohlc.rs to candlestick.rs, removes the now deprecated ohlc code, and completes the following parts of Issue #695: - [x] Ensure tests exist for all public API - [x] Remove toolkit_experimental tags and update test usages - [x] Add arrow operators for accessors if applicable - [x] Ensure arrow operators have test coverage - [x] If present, ensure combine and rollup are tested - [x] Add serialization tests for on disk format - [x] Add serialization tests for text output format - [x] Add upgrade tests - [x] Add continuous aggregate test Co-authored-by: Thomas Hatzopoulos <thomas@timescale.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
bors r- |
|
Canceled. |
|
Build succeeded: |
This PR renames ohlc.rs to candlestick.rs, removes the now deprecated ohlc code, and completes the following parts of Issue #695: