-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsorted decompressed chunk path even if we have sorted ones #6879
Draft
akuzm
wants to merge
97
commits into
timescale:main
Choose a base branch
from
akuzm:unsorted
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 3, 2024
-
Add unsorted decompressed chunk path even if we have sorted ones
The unsorted paths are better for hash aggregation, but currently in this case we are only going to add sorted paths.
Configuration menu - View commit details
-
Copy full SHA for 76c1f97 - Browse repository at this point
Copy the full SHA 76c1f97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 868d253 - Browse repository at this point
Copy the full SHA 868d253View commit details -
Configuration menu - View commit details
-
Copy full SHA for eef6db3 - Browse repository at this point
Copy the full SHA eef6db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9d1c3 - Browse repository at this point
Copy the full SHA ca9d1c3View commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f7b1ec5 - Browse repository at this point
Copy the full SHA f7b1ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 848c6ee - Browse repository at this point
Copy the full SHA 848c6eeView commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 397717d - Browse repository at this point
Copy the full SHA 397717dView commit details -
Fix the flaky merge_append_partially_compressed test
Add ANALYZE. To keep the desired MergeAppend plans, we also have to add a LIMIT everywhere so that the MergeAppend is chosen based on its lower startup cost. Otherwise the plain Sort over Append will be chosen because for small tables its cost is less.
Configuration menu - View commit details
-
Copy full SHA for b975589 - Browse repository at this point
Copy the full SHA b975589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7643343 - Browse repository at this point
Copy the full SHA 7643343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f5b34f - Browse repository at this point
Copy the full SHA 4f5b34fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68062c7 - Browse repository at this point
Copy the full SHA 68062c7View commit details -
Fix some flakiness in transparent_decompression test
Add ANALYZE after compression. The plan changes are expected, SeqScans are preferred over IndexScans and Sort over MergeAppend for small tables.
Configuration menu - View commit details
-
Copy full SHA for 2767664 - Browse repository at this point
Copy the full SHA 2767664View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0f4ebc - Browse repository at this point
Copy the full SHA f0f4ebcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b1bac - Browse repository at this point
Copy the full SHA c8b1bacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f2764f - Browse repository at this point
Copy the full SHA 5f2764fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06c087b - Browse repository at this point
Copy the full SHA 06c087bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d44042 - Browse repository at this point
Copy the full SHA 5d44042View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3476da5 - Browse repository at this point
Copy the full SHA 3476da5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ffd24a - Browse repository at this point
Copy the full SHA 5ffd24aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fba0f5 - Browse repository at this point
Copy the full SHA 4fba0f5View commit details -
Remove unneeded Sort over Sort
We would add extra Sort nodes when adjusting the children of space partitioning MergeAppend under ChunkAppend. This is not needed because MergeAppend plans add the required Sort themselves, and in general no adjustment seems to be required for the MergeAppend children specifically there.
Configuration menu - View commit details
-
Copy full SHA for 0951fb0 - Browse repository at this point
Copy the full SHA 0951fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bbf5df - Browse repository at this point
Copy the full SHA 5bbf5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2670505 - Browse repository at this point
Copy the full SHA 2670505View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b62a11 - Browse repository at this point
Copy the full SHA 3b62a11View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7e656a - Browse repository at this point
Copy the full SHA d7e656aView commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f92a7ca - Browse repository at this point
Copy the full SHA f92a7caView commit details -
Configuration menu - View commit details
-
Copy full SHA for b04d9fb - Browse repository at this point
Copy the full SHA b04d9fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6be134e - Browse repository at this point
Copy the full SHA 6be134eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e496c0 - Browse repository at this point
Copy the full SHA 5e496c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0859a3a - Browse repository at this point
Copy the full SHA 0859a3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e509896 - Browse repository at this point
Copy the full SHA e509896View commit details -
Configuration menu - View commit details
-
Copy full SHA for f50947e - Browse repository at this point
Copy the full SHA f50947eView commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f45fa6e - Browse repository at this point
Copy the full SHA f45fa6eView commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c5e89c6 - Browse repository at this point
Copy the full SHA c5e89c6View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51c734c - Browse repository at this point
Copy the full SHA 51c734cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d2acc1 - Browse repository at this point
Copy the full SHA 5d2acc1View commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f80c21a - Browse repository at this point
Copy the full SHA f80c21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6343044 - Browse repository at this point
Copy the full SHA 6343044View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e60f30 - Browse repository at this point
Copy the full SHA 5e60f30View commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a27712 - Browse repository at this point
Copy the full SHA 6a27712View commit details -
Configuration menu - View commit details
-
Copy full SHA for acc14cf - Browse repository at this point
Copy the full SHA acc14cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc0ceb - Browse repository at this point
Copy the full SHA bdc0cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for f601114 - Browse repository at this point
Copy the full SHA f601114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 451b60f - Browse repository at this point
Copy the full SHA 451b60fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c465b58 - Browse repository at this point
Copy the full SHA c465b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8dfb2a - Browse repository at this point
Copy the full SHA e8dfb2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a660b - Browse repository at this point
Copy the full SHA e5a660bView commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51fc7a2 - Browse repository at this point
Copy the full SHA 51fc7a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a75d46 - Browse repository at this point
Copy the full SHA 6a75d46View commit details -
Configuration menu - View commit details
-
Copy full SHA for e88d7a6 - Browse repository at this point
Copy the full SHA e88d7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ac83d8 - Browse repository at this point
Copy the full SHA 5ac83d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ff0bd1 - Browse repository at this point
Copy the full SHA 6ff0bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 780ec7d - Browse repository at this point
Copy the full SHA 780ec7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f53983a - Browse repository at this point
Copy the full SHA f53983aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d05527 - Browse repository at this point
Copy the full SHA 7d05527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e789c4 - Browse repository at this point
Copy the full SHA 0e789c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65583c8 - Browse repository at this point
Copy the full SHA 65583c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3269794 - Browse repository at this point
Copy the full SHA 3269794View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fa86fd - Browse repository at this point
Copy the full SHA 0fa86fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 211e3a5 - Browse repository at this point
Copy the full SHA 211e3a5View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad7c269 - Browse repository at this point
Copy the full SHA ad7c269View commit details -
Configuration menu - View commit details
-
Copy full SHA for 611aa73 - Browse repository at this point
Copy the full SHA 611aa73View commit details -
Configuration menu - View commit details
-
Copy full SHA for c48faf5 - Browse repository at this point
Copy the full SHA c48faf5View commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b45a8d2 - Browse repository at this point
Copy the full SHA b45a8d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e16fcc - Browse repository at this point
Copy the full SHA 8e16fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 561abdc - Browse repository at this point
Copy the full SHA 561abdcView commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be54bb6 - Browse repository at this point
Copy the full SHA be54bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 267cc31 - Browse repository at this point
Copy the full SHA 267cc31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ad1dc - Browse repository at this point
Copy the full SHA 21ad1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 033c6c9 - Browse repository at this point
Copy the full SHA 033c6c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c22b2d7 - Browse repository at this point
Copy the full SHA c22b2d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d40119f - Browse repository at this point
Copy the full SHA d40119fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a3c167 - Browse repository at this point
Copy the full SHA 8a3c167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 842e044 - Browse repository at this point
Copy the full SHA 842e044View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f2bb7f - Browse repository at this point
Copy the full SHA 0f2bb7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f5201 - Browse repository at this point
Copy the full SHA 30f5201View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c1a0be4 - Browse repository at this point
Copy the full SHA c1a0be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b86bdd3 - Browse repository at this point
Copy the full SHA b86bdd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dba8293 - Browse repository at this point
Copy the full SHA dba8293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a1926 - Browse repository at this point
Copy the full SHA 85a1926View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dfd578 - Browse repository at this point
Copy the full SHA 5dfd578View commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0039a6f - Browse repository at this point
Copy the full SHA 0039a6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b81b42 - Browse repository at this point
Copy the full SHA 8b81b42View commit details -
Choose cheapest aggregated path as base for chunk-wise aggregation
Currently we use the cheapest path before final aggregation for this (i.e. Append over individual chunks), but it does not consider the cost of a Sort that might be required before aggregation. To account for this, use instead the child path of the cheapest final aggregated path.
Configuration menu - View commit details
-
Copy full SHA for 20ff42b - Browse repository at this point
Copy the full SHA 20ff42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9508a3 - Browse repository at this point
Copy the full SHA f9508a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca447a - Browse repository at this point
Copy the full SHA cca447aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 561cd28 - Browse repository at this point
Copy the full SHA 561cd28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 371c9ae - Browse repository at this point
Copy the full SHA 371c9aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2516cec - Browse repository at this point
Copy the full SHA 2516cecView commit details
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 769a346 - Browse repository at this point
Copy the full SHA 769a346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fe7c52 - Browse repository at this point
Copy the full SHA 5fe7c52View commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 20b6940 - Browse repository at this point
Copy the full SHA 20b6940View commit details -
Configuration menu - View commit details
-
Copy full SHA for e017290 - Browse repository at this point
Copy the full SHA e017290View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0d9c44 - Browse repository at this point
Copy the full SHA b0d9c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for c66df25 - Browse repository at this point
Copy the full SHA c66df25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b9e42b - Browse repository at this point
Copy the full SHA 3b9e42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3f53d0 - Browse repository at this point
Copy the full SHA a3f53d0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.