Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsorted decompressed chunk path even if we have sorted ones #6879

Draft
wants to merge 97 commits into
base: main
Choose a base branch
from

Commits on May 3, 2024

  1. Add unsorted decompressed chunk path even if we have sorted ones

    The unsorted paths are better for hash aggregation, but currently in
    this case we are only going to add sorted paths.
    akuzm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    76c1f97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    868d253 View commit details
    Browse the repository at this point in the history
  3. ref

    akuzm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    eef6db3 View commit details
    Browse the repository at this point in the history
  4. set all parameters

    akuzm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ca9d1c3 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    f7b1ec5 View commit details
    Browse the repository at this point in the history
  2. simplify?

    akuzm committed May 6, 2024
    Configuration menu
    Copy the full SHA
    848c6ee View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. tmp debug

    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    397717d View commit details
    Browse the repository at this point in the history
  2. Fix the flaky merge_append_partially_compressed test

    Add ANALYZE. To keep the desired MergeAppend plans, we also have to add
    a LIMIT everywhere so that the MergeAppend is chosen based on its lower
    startup cost. Otherwise the plain Sort over Append will be chosen
    because for small tables its cost is less.
    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b975589 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7643343 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f5b34f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    68062c7 View commit details
    Browse the repository at this point in the history
  6. Fix some flakiness in transparent_decompression test

    Add ANALYZE after compression. The plan changes are expected, SeqScans
    are preferred over IndexScans and Sort over MergeAppend for small
    tables.
    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2767664 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f0f4ebc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c8b1bac View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5f2764f View commit details
    Browse the repository at this point in the history
  10. add vacuum as well

    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    06c087b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5d44042 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3476da5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5ffd24a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4fba0f5 View commit details
    Browse the repository at this point in the history
  15. Remove unneeded Sort over Sort

    We would add extra Sort nodes when adjusting the children of space
    partitioning MergeAppend under ChunkAppend. This is not needed because
    MergeAppend plans add the required Sort themselves, and in general no
    adjustment seems to be required for the MergeAppend children
    specifically there.
    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0951fb0 View commit details
    Browse the repository at this point in the history
  16. capitalization

    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5bbf5df View commit details
    Browse the repository at this point in the history
  17. add vacuum

    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2670505 View commit details
    Browse the repository at this point in the history
  18. vacuum analyze

    akuzm committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3b62a11 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d7e656a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    f92a7ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b04d9fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6be134e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e496c0 View commit details
    Browse the repository at this point in the history
  5. bigger table?

    akuzm committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0859a3a View commit details
    Browse the repository at this point in the history
  6. even less changes

    akuzm committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e509896 View commit details
    Browse the repository at this point in the history
  7. even bigger table?

    akuzm committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f50947e View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Revert "even bigger table?"

    This reverts commit f50947e.
    akuzm committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f45fa6e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. debug

    akuzm committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c5e89c6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. add some asymmetry

    akuzm committed May 16, 2024
    Configuration menu
    Copy the full SHA
    51c734c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d2acc1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. debug solo test

    akuzm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f80c21a View commit details
    Browse the repository at this point in the history
  2. add vacuum

    akuzm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6343044 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e60f30 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    6a27712 View commit details
    Browse the repository at this point in the history
  2. add some limits

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    acc14cf View commit details
    Browse the repository at this point in the history
  3. ref

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    bdc0ceb View commit details
    Browse the repository at this point in the history
  4. smaller limit

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f601114 View commit details
    Browse the repository at this point in the history
  5. limit 11

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    451b60f View commit details
    Browse the repository at this point in the history
  6. work_mem 10MB

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c465b58 View commit details
    Browse the repository at this point in the history
  7. 1 MB

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e8dfb2a View commit details
    Browse the repository at this point in the history
  8. no limit

    akuzm committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e5a660b View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    51fc7a2 View commit details
    Browse the repository at this point in the history
  2. no limit fixed

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6a75d46 View commit details
    Browse the repository at this point in the history
  3. Revert "no limit"

    This reverts commit e5a660b.
    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e88d7a6 View commit details
    Browse the repository at this point in the history
  4. limit 11 again

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5ac83d8 View commit details
    Browse the repository at this point in the history
  5. work_mem 64kB

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    6ff0bd1 View commit details
    Browse the repository at this point in the history
  6. Revert "limit 11 again"

    This reverts commit 5ac83d8.
    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    780ec7d View commit details
    Browse the repository at this point in the history
  7. no limit again

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f53983a View commit details
    Browse the repository at this point in the history
  8. limit 11 again

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7d05527 View commit details
    Browse the repository at this point in the history
  9. Revert "no limit fixed"

    This reverts commit 6a75d46.
    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0e789c4 View commit details
    Browse the repository at this point in the history
  10. limit 11

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    65583c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3269794 View commit details
    Browse the repository at this point in the history
  12. ref

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0fa86fd View commit details
    Browse the repository at this point in the history
  13. try something else

    akuzm committed May 29, 2024
    Configuration menu
    Copy the full SHA
    211e3a5 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. disable sort in more places

    akuzm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ad7c269 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    611aa73 View commit details
    Browse the repository at this point in the history
  3. disable sort in more test

    akuzm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c48faf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. more cases

    akuzm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b45a8d2 View commit details
    Browse the repository at this point in the history
  2. one more

    akuzm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8e16fcc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    561abdc View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    be54bb6 View commit details
    Browse the repository at this point in the history
  2. cleanup

    akuzm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    267cc31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    21ad1dc View commit details
    Browse the repository at this point in the history
  4. cleanup

    akuzm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    033c6c9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c22b2d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d40119f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8a3c167 View commit details
    Browse the repository at this point in the history
  8. cleanup

    akuzm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    842e044 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0f2bb7f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    30f5201 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    c1a0be4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b86bdd3 View commit details
    Browse the repository at this point in the history
  3. tmp wrong[:

    akuzm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    dba8293 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    85a1926 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5dfd578 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. temp debug

    akuzm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0039a6f View commit details
    Browse the repository at this point in the history
  2. small fix

    akuzm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8b81b42 View commit details
    Browse the repository at this point in the history
  3. Choose cheapest aggregated path as base for chunk-wise aggregation

    Currently we use the cheapest path before final aggregation for this
    (i.e. Append over individual chunks), but it does not consider the cost
    of a Sort that might be required before aggregation. To account for
    this, use instead the child path of the cheapest final aggregated path.
    akuzm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    20ff42b View commit details
    Browse the repository at this point in the history
  4. test refs

    akuzm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f9508a3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cca447a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    561cd28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    371c9ae View commit details
    Browse the repository at this point in the history
  8. cleanup after merge

    akuzm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2516cec View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    769a346 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fe7c52 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. parallel plans

    akuzm committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    20b6940 View commit details
    Browse the repository at this point in the history
  2. remove debug

    akuzm committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e017290 View commit details
    Browse the repository at this point in the history
  3. easier diff

    akuzm committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b0d9c44 View commit details
    Browse the repository at this point in the history
  4. cleanup

    akuzm committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c66df25 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3b9e42b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a3f53d0 View commit details
    Browse the repository at this point in the history