Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch release PR creation scripts #7062

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pallavisontakke
Copy link
Contributor

@pallavisontakke pallavisontakke commented Jun 25, 2024

For the version branch.

Issue: https://github.com/timescale/eng-database/issues/613

Disable-check: force-changelog-file
Disable-check: commit-count

@pallavisontakke pallavisontakke requested review from fabriziomello, antekresic and svenklemm and removed request for antekresic and svenklemm June 25, 2024 07:46
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (59f50f2) to head (fb25c89).
Report is 547 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7062      +/-   ##
==========================================
+ Coverage   80.06%   82.25%   +2.19%     
==========================================
  Files         190      229      +39     
  Lines       37181    41694    +4513     
  Branches     9450    10716    +1266     
==========================================
+ Hits        29770    34297    +4527     
- Misses       2997     3120     +123     
+ Partials     4414     4277     -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of supplying them externally.
Accordingly also edit it in the next script.
From git config, instead of CLI input.
For git user parameters setup.
Concerning issue timescale/eng-database#623

Automate minor release : Release PR (for *.*.x branch) creation.
In a different way.
As naming of these files is not consistent.
a bit more, as per review comment.
variables using sed, in release-automation-scripts
from RELEASE_NOTES_HEADER.md.j2.
As now this section is commented in the above header file itself.
From current CHANGELOG.md , instead of keeping it a fixed number of lines.
To fix the shellcheck style issue:
^-- SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
cut -d '(' -f1 < ~/CHANGELOG_"$NEW_VERSION".md > ~/CHANGELOG_"$NEW_VERSION".md.tmp
mv ~/CHANGELOG_"$NEW_VERSION".md.tmp ~/CHANGELOG_"$NEW_VERSION".md

git commit -a -F ~/CHANGELOG_"$NEW_VERSION".md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git commit -a -F ~/CHANGELOG_"$NEW_VERSION".md
git commit --no-verify -a -F ~/CHANGELOG_"$NEW_VERSION".md

To don't trigger commit hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants