Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert for fetch_att and store_att_byval #7365

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Oct 18, 2024

These two functions throw an error if you pass in a strange combination of typbyval and typlen, so we assert on bad values to get a backtrace.

Disable-check: force-changelog-file

@mkindahl mkindahl force-pushed the assert-on-bad-byval branch 2 times, most recently from 6e50eec to 39365be Compare October 18, 2024 12:16
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (59f50f2) to head (0cff399).
Report is 561 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.h 66.66% 0 Missing and 1 partial ⚠️
tsl/src/compression/algorithms/datum_serialize.c 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7365      +/-   ##
==========================================
+ Coverage   80.06%   82.55%   +2.49%     
==========================================
  Files         190      229      +39     
  Lines       37181    42731    +5550     
  Branches     9450    10734    +1284     
==========================================
+ Hits        29770    35278    +5508     
- Misses       2997     3168     +171     
+ Partials     4414     4285     -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkindahl mkindahl marked this pull request as ready for review October 18, 2024 13:15
@mkindahl mkindahl force-pushed the assert-on-bad-byval branch 2 times, most recently from 5181ee8 to 281f1fa Compare October 20, 2024 08:21
These two functions throw an error if you pass in a strange combination
of typbyval and typlen, so we assert on bad values to get a backtrace.
@mkindahl mkindahl merged commit f754918 into timescale:main Oct 22, 2024
43 of 45 checks passed
@mkindahl mkindahl deleted the assert-on-bad-byval branch October 22, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants