Backport to 2.18.x: #7711: Load hypercore handler eagerly #7717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timescale-automation
added
the
is-auto-backport
fabriziomello
force-pushed
the
backport/2.18.x/7711
branch
from
426f94d to
6b37c8c
Compare
If a crossmodule wrapper function is called as part of a query on a fresh backend, it will generate a license error even if the license is set correctly. This happens because the module load happens very late (in `post_parse_analyze_hook`) but the function call is quite early. This is fixed by eagerly loading the TSL module in the hypercore handler function and hypercore index proxy handler function. (cherry picked from commit 63ccf6a)
fabriziomello
force-pushed
the
backport/2.18.x/7711
branch
from
635a418 to
7d0c971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #7711: Load hypercore handler eagerly.
The original issue is #7702.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Load hypercore handler eagerly
If a crossmodule wrapper function is called as part of a query on a fresh backend, it will generate a license error even if the license is set correctly. This happens because the module load happens very late (in
post_parse_analyze_hook) but the function call is quite early.This is fixed by eagerly loading the TSL module in the hypercore handler function and hypercore index proxy handler function.