Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument d_headis not used in TSiTPlus #380

Closed
vrodriguezf opened this issue Jan 23, 2022 · 2 comments
Closed

Argument d_headis not used in TSiTPlus #380

vrodriguezf opened this issue Jan 23, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@vrodriguezf
Copy link
Contributor

def __init__(self, c_in:int, seq_len:int, depth:int=6, d_model:int=128, n_heads:int=16, d_head:Optional[int]=None, act:str='gelu',

oguiza pushed a commit that referenced this issue Jan 25, 2022
@oguiza
Copy link
Contributor

oguiza commented Jan 25, 2022

Good catch, @vrodriguezf!
I've checked the ViT implementation that is the one I used as a blueprint to create TSiT and it doesn't use the d_head argument. So based on this, I decided to drop it. I've already fixed this issue in GitHub.

@oguiza oguiza added the bug Something isn't working label Jan 25, 2022
@oguiza
Copy link
Contributor

oguiza commented Jan 25, 2022

I'll close this issue since I've checked that d_head is no longer an argument in TSiT in GitHub.

@oguiza oguiza closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants