Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResNetPlus, FCNPlus, InceptionRocketPlus, MiniRocketPlus and XResNet1dPlus don't work with ndim fcst targets #718

Closed
oguiza opened this issue Mar 24, 2023 · 0 comments
Labels
bug Something isn't working under review Waiting for clarification, confirmation, etc

Comments

@oguiza
Copy link
Contributor

oguiza commented Mar 24, 2023

All these architectures fail the following test:

from tsai.basics import *
from tsai.learner import all_arch_names

X=torch.rand(8,2,50)
y=torch.rand(8,1)
splits = TimeSplitter(show_plot=False)(y)

fail_test = []
for arch in all_arch_names:
    if not "plus" in arch.lower(): continue
    try:
        fcst = TSForecaster(X, y, splits=splits, arch=arch, metrics=mse)
        with ContextManagers([fcst.no_bar(), fcst.no_logging()]):
            fcst.fit_one_cycle(1, 1e-3)
    except Exception as e: 
        fail_test.append(arch)
        print(arch, e)

test_eq(fail_test, [])

Need to confirm if it's possible to update them so that they can be used with multidimensional targets.

@oguiza oguiza changed the title ResNetPlus, FCNPlus, InceptionRocketPlus, MiniRocketPlus and XResNet1dPlus don't with with multidimensional targets ResNetPlus, FCNPlus, InceptionRocketPlus, MiniRocketPlus and XResNet1dPlus don't with with multidimensional fcst targets Mar 25, 2023
@oguiza oguiza changed the title ResNetPlus, FCNPlus, InceptionRocketPlus, MiniRocketPlus and XResNet1dPlus don't with with multidimensional fcst targets ResNetPlus, FCNPlus, InceptionRocketPlus, MiniRocketPlus and XResNet1dPlus don't work with ndim fcst targets Mar 25, 2023
@oguiza oguiza added the under review Waiting for clarification, confirmation, etc label Mar 25, 2023
oguiza added a commit that referenced this issue Mar 26, 2023
oguiza added a commit that referenced this issue Mar 26, 2023
@oguiza oguiza closed this as completed in 10e70f0 Mar 26, 2023
@oguiza oguiza added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working under review Waiting for clarification, confirmation, etc
Projects
None yet
Development

No branches or pull requests

1 participant