Support zlib compression #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youdongguo
commented
May 25, 2022
src/MzXML.jl
Outdated
| @@ -241,7 +241,7 @@ function Base.copyto!(dest::AxisArray, src::Vector{<:MSscan}) | |||
| axmz, axt = AxisArrays.axes(dest, Axis{:mz}), AxisArrays.axes(dest, Axis{:time}) | |||
| fill!(dest, 0) | |||
| for scan in src | |||
| j, ft = val2index(axt, scan.retentionTime) | |||
| j, ft = val2index(axt, scan.retentionTime.val) | |||
There was a problem hiding this comment.
axt is a range like 0:1:10, scan.retentionTime is a "Quatity" like 2s (where s is second). then, operations like "scan.retentionTime - 2" would throw bugs. scan.retentionTime.val will return the value of this "Quantity".
added 2 commits
May 26, 2022 15:13
This reverts commit 21c74b5.
|
New release: JuliaRegistries/General#61111 |
|
This hasn't been registered yet because of [compat]. See JuliaRegistries/General#61111. It might be good practice for you to fix it, seem reasonable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.