Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isvalid_cache_header logic #1

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

IanButterworth
Copy link
Collaborator

Before this I was getting

julia> info_cachefile("Revise")
ERROR: TypeError: non-boolean (UInt64) used in boolean context
Stacktrace:
 [1] macro expansion
   @ ~/Documents/GitHub/PkgCacheInspector.jl/src/PkgCacheInspector.jl:107 [inlined]
 [2] macro expansion
   @ ./lock.jl:267 [inlined]
 [3] info_cachefile(pkg::Base.PkgId, path::String)
   @ PkgCacheInspector ~/Documents/GitHub/PkgCacheInspector.jl/src/PkgCacheInspector.jl:103
 [4] info_cachefile(pkg::Base.PkgId)
   @ PkgCacheInspector ~/Documents/GitHub/PkgCacheInspector.jl/src/PkgCacheInspector.jl:136
 [5] info_cachefile(pkgname::String)
   @ PkgCacheInspector ~/Documents/GitHub/PkgCacheInspector.jl/src/PkgCacheInspector.jl:139
 [6] top-level scope
   @ REPL[2]:1

With this

julia> info_cachefile("Revise")
Contents of /Users/ian/.julia/compiled/v1.10/Revise/M1Qoh_1DCqx.ji:
  modules: Any[Revise]
  init order: Any[Revise]
  115 external methods
  1701 new specializations of external methods (Base 81.5%, Base.Iterators 3.9%, Base.Broadcast 3.1%, ...)
  347 external methods with new roots
  12497 external targets
  9370 edges
  Segment sizes (bytes):
  system:      3304304 ( 55.69%)
  isbits:      2304751 ( 38.84%)
  symbols:       26597 (  0.45%)
  tags:          45520 (  0.77%)
  relocations:  252605 (  4.26%)
  gvars:             0 (  0.00%)
  fptrs:             0 (  0.00%)

@timholy timholy added needs test Add test(s) before merging and removed needs test Add test(s) before merging labels Dec 1, 2022
@timholy timholy merged commit 99e4e18 into timholy:main Dec 1, 2022
@IanButterworth IanButterworth deleted the ib/fix branch December 1, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants