Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if increasing delay helps entr tests pass on OSX #336

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

timholy
Copy link
Owner

@timholy timholy commented Aug 23, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #336 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #336      +/-   ##
=========================================
- Coverage   76.88%   76.8%   -0.08%     
=========================================
  Files          11      11              
  Lines        1168    1164       -4     
=========================================
- Hits          898     894       -4     
  Misses        270     270
Impacted Files Coverage Δ
src/utils.jl 50% <0%> (-2.71%) ⬇️
src/pkgs.jl 90.86% <0%> (-0.09%) ⬇️
src/types.jl 53.33% <0%> (ø) ⬆️
src/Revise.jl 72.59% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7d161...3793ee9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #336 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #336      +/-   ##
=========================================
- Coverage   76.88%   76.8%   -0.08%     
=========================================
  Files          11      11              
  Lines        1168    1164       -4     
=========================================
- Hits          898     894       -4     
  Misses        270     270
Impacted Files Coverage Δ
src/utils.jl 50% <0%> (-2.71%) ⬇️
src/pkgs.jl 90.86% <0%> (-0.09%) ⬇️
src/types.jl 53.33% <0%> (ø) ⬆️
src/Revise.jl 72.59% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7d161...3793ee9. Read the comment docs.

@timholy
Copy link
Owner Author

timholy commented Sep 3, 2019

The only failures here were travis timeouts, so I think this solves the specific problem. Timeouts will be a separate PR.

@timholy timholy merged commit e22ec82 into master Sep 3, 2019
@timholy timholy deleted the teh/entr_delay branch September 3, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant