Eliminate most usages of asynchronous processing #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
force-pushed
the
teh/fix_nightly
branch
from
de91eb5
to
9ade7d5
Compare
timholy
changed the title
On nightly, the Revise tests hang when code_coverage=true. This seems to be a consequence of new locking in the `Base.require` pipeline while executing package operations in a different task, for which attempting to take the lock from a different task fails.
Similar to the previous commit, `watch_package` also executes operations that are now protected by `Base.require_lock`. Making this synchronous eliminates the risk of changing task order.
timholy
force-pushed
the
teh/fix_nightly
branch
from
9ade7d5
to
8349c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locking of
require_lockchanges the order in which package callbacks run when two things come together:require_lockThis eliminates the asynchronous processing, at the cost of about 200ms extra "visible" latency when loading ImageCore. The increased latency is only a consequence of the second commit; it would be better to drop it, in which case it would be necessary to add a
yield()afterRevise.jl/test/runtests.jl
Line 3469 in dcae051
Revise.jl/test/runtests.jl
Line 3554 in dcae051