Skip to content

Conversation

@Keno
Copy link
Collaborator

@Keno Keno commented Jul 25, 2024

With this and the LCU fixes, Revise should pass tests again on 1.12.

With this and the LCU fixes, Revise should pass tests again on 1.12.
@Keno
Copy link
Collaborator Author

Keno commented Jul 26, 2024

Updated to bump LCU and cherry-pick the additional fixes from #829

@KristofferC
Copy link
Collaborator

Interesting that the linux testers don't know about LCU 3.0.1.

@Keno Keno closed this Jul 26, 2024
@Keno Keno reopened this Jul 26, 2024
@Keno
Copy link
Collaborator Author

Keno commented Jul 26, 2024

Probably just hadn't propagated yet. Rerunning.

@Keno
Copy link
Collaborator Author

Keno commented Jul 28, 2024

@timholy The last issue here is that ExponentialUtilities v1.9.0 is not compatible with all the julia versions we want to test. Can we switch this test to be more self contained and include some minimal in the test code itself rather than depending on some external package?

@Keno
Copy link
Collaborator Author

Keno commented Jul 28, 2024

That's mostly a separate change though. I would propose merging this first and then addressing that last issue.

@timholy
Copy link
Owner

timholy commented Jul 28, 2024

Can we switch this test to be more self contained and include some minimal in the test code itself rather than depending on some external package?

Yes, that needs to happen. I have been doing that for newer tests, but I haven't migrated old tests. Doesn't need to stand in the way of this PR.

@Keno Keno merged commit 758d5fd into timholy:master Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants