Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bound assumption for SnoopCompile bot #80

Closed
aminya opened this issue May 12, 2020 · 1 comment · Fixed by #71
Closed

Version bound assumption for SnoopCompile bot #80

aminya opened this issue May 12, 2020 · 1 comment · Fixed by #71

Comments

@aminya
Copy link
Contributor

aminya commented May 12, 2020

When the user gives

version = [v"1.4.1",v"1.2.0"]

The following code is considered:

@static if VERSION < v"1.2.0"
    # nothing - `snoopi_bot` isn't supported for `VERSION < v"1.2"` yet.
elseif VERSION <= v"1.2.0"
    include("$precompiles_rootpath_rel//1.2.0/precompile_TestPackage0.jl")
    _precompile_()
elseif VERSION <= v"1.4.1"
    include("$precompiles_rootpath_rel//1.4.1/precompile_TestPackage0.jl")
    _precompile_()
else
end

The assumption is that for lower versions the same precompilation signatures should be used.

Should we make this more limited and assume that the signatures are only valid for minor version changes? For example, if the user gives v"1.4.1", the following should be considered instead?

elseif v"1.4.0" <= VERSION <= v"1.4.1"
                 

What should be the assumption?

aminya added a commit to aminya/SnoopCompile.jl that referenced this issue May 16, 2020
@aminya
Copy link
Contributor Author

aminya commented May 16, 2020

I fixed this in aminya@beb46d2 by assuming that precompilation is the same for all patch versions.

giving v"1.4.1" will give:

elseif v"1.4.0" <= VERSION <= v"1.4.9"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant