Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors (node-gyp) stemming from bunyan/dtrace-provider deps #37

Closed
scottadamsmith opened this issue Oct 14, 2019 · 5 comments · Fixed by #85
Closed

Build errors (node-gyp) stemming from bunyan/dtrace-provider deps #37

scottadamsmith opened this issue Oct 14, 2019 · 5 comments · Fixed by #85

Comments

@scottadamsmith
Copy link

Is anyone else getting node-gyp errors related from the Bunyan dependency? I've read through various issues in the Bunyan and dtrace-provider repositories, but haven't found a concrete way around this that doesn't involve:

A) Installing python
B) Installing the windows essentials package
C) Manually editing the package-lock

Mainly just curious if anyone else is seeing this and if they have found a good workaround or if there is something we could change in the package.json to resolve the issue for everyone.

@timkindberg
Copy link
Owner

I've not seen these errors. This seems related: trentm/node-bunyan#570

What version of node/npm are you on?

@scottadamsmith
Copy link
Author

Yeah, it definitely appears to be stemming from that library. I am on Node 10.14.2 and NPM 6.5.0

@scottadamsmith
Copy link
Author

I ended up just having to find another way to make my assertion as I wasn't able to figure out how to resolve this. I'm sure I'll give it another shot in the future as I really want to have this at my disposal when testing. Perhaps the dependency will have fixed the issue by then. Feel free to close if you want unless you are still looking into it.

@timkindberg
Copy link
Owner

Sorry you had trouble with it.

@AndrewSouthpaw
Copy link
Contributor

AndrewSouthpaw commented Sep 18, 2021

I still see build errors like these, and the root cause seems to be bunyan:

$ npm i -D jest-when

> dtrace-provider@0.8.8 install /Users/.../node_modules/dtrace-provider
> node-gyp rebuild || node suppress-error.js

  ACTION binding_gyp_ndtp_target_build_ndtp .
-----------------------------------------------------------------
Building dtrace-provider failed with exit code 1, falling back
on stub implementation.

Re-run install with V set in your environment to see the build
output, or NODE_DTRACE_PROVIDER_REQUIRE=hard to force an
installation failure.
-----------------------------------------------------------------
  TOUCH Release/obj.target/ndtp.stamp
+ jest-when@3.3.1
added 31 packages from 70 contributors and audited 1616 packages in 13.351s

I'm going to take a stab at removing the bunyan dependency, it doesn't seem like the logging functionality used for the library is all that advanced and it'd be nice to trim this dependency that seems to cause build issues frequently.

Here's my env:

npx envinfo

System:
OS: macOS Mojave 10.14.6
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Memory: 524.25 MB / 32.00 GB
Shell: 5.0.11 - /usr/local/bin/bash
Binaries:
Node: 14.15.5 - ~/.nvm/versions/node/v14.15.5/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.11 - ~/.nvm/versions/node/v14.15.5/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Utilities:
Make: 3.81 - /usr/bin/make
GCC: 4.2.1 - /usr/bin/gcc
Git: 2.24.0 - /usr/local/bin/git
Clang: 1100.0.33.17 - /usr/bin/clang
Subversion: 1.10.4 - /usr/bin/svn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants