Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging functionality and drop bunyan dependency. #85

Conversation

AndrewSouthpaw
Copy link
Contributor

@AndrewSouthpaw AndrewSouthpaw commented Sep 18, 2021

Closes #37.

Generally seems like bunyan has trouble building on people's machines for reasons that I cannot understand, but given the minor role the logger plays it seems overkill to bring in such a fully-featured logger.

I subbed it out with diary, which is super fast, tiny, and does the trick. It creates a scoped logger, which is silent by default, unless you choose to listen to it:

const { enable } = require('diary')

enable('*') // allow everything
enable('jest-when: my-logger') // allow a specific logger

If we wanted to move forward with these changes, it'd be worth mentioning the functionality in the README.

But honestly, I think it'd be better to drop the logger entirely. It's not a feature people know about, and I'm not convinced it's worth keeping a logger around anyway. It just adds another dependency, and I'm not sure anyone would use it.

If @timkindberg agrees, I can completely pull out the logger code so this library stays as slim as possible.

[EDIT]

Based off discussion, changing this PR to fully remove logging functionality and dependencies.

@timkindberg
Copy link
Owner

Let's just remove it

@AndrewSouthpaw AndrewSouthpaw changed the title Replace bunyan with more stable, zero-dependency logger. Remove logging functionality. Sep 18, 2021
@AndrewSouthpaw AndrewSouthpaw changed the title Remove logging functionality. Remove logging functionality and drop bunyan dependency. Sep 18, 2021
@AndrewSouthpaw
Copy link
Contributor Author

Updated!

@timkindberg timkindberg merged commit d591350 into timkindberg:master Sep 19, 2021
@AndrewSouthpaw AndrewSouthpaw deleted the replace-bunyan-with-smaller-logger branch September 20, 2021 13:51
@AndrewSouthpaw
Copy link
Contributor Author

Thanks for accepting my PR! This is a great library, and does exactly what I needed. 😄

@timkindberg
Copy link
Owner

Hey thanks for the kind words and the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors (node-gyp) stemming from bunyan/dtrace-provider deps
2 participants